Adds check for Wearable API #137
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @garanj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical issue where applications attempting to use Wearable APIs on devices without Google Play Services (or other unsupported configurations) would encounter fatal errors. By integrating a new "WearableApiAvailability" utility, the "WearAssetTransmitter" and "WearDeviceRepository" components now proactively check for API presence, ensuring the application operates stably and gracefully handles scenarios where Wearable functionality is not available, preventing crashes and providing appropriate fallback behavior.
Highlights
- New Wearable API Availability Check Utility: Introduced a new utility object, "WearableApiAvailability", to centralize the logic for checking if Google's Wearable APIs are accessible on the current device, preventing crashes on unsupported devices.
- Graceful Handling in WearAssetTransmitter: The "WearAssetTransmitter" now checks for Wearable API availability before attempting to register a "MessageClient.OnMessageReceivedListener". If the API is unavailable, it gracefully reports no ongoing transmission.
- Robust Device Detection in WearDeviceRepository: The "WearDeviceRepository" now performs an API availability check before attempting to query connected Wear OS devices. If the API is not available, it reports that no watch is connected, avoiding fatal errors.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request effectively addresses a potential crash by adding checks for the Wearable API's availability on devices where it might be missing. The introduction of the WearableApiAvailability object is a good, reusable approach. My review includes a few suggestions for improving code style and removing an unused variable to enhance maintainability. Overall, this is a solid improvement to the application's robustness.
...e/src/main/java/com/android/developers/androidify/watchface/transfer/WearDeviceRepository.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/android/developers/androidify/watchface/transfer/WearableApiAvailability.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/android/developers/androidify/watchface/transfer/WearableApiAvailability.kt
Outdated
Show resolved
Hide resolved
2 participants
Some devices (phones without Play Services, possibly tablets?) don't have access to the Wearable APIs. Attempting to invoke them on these devices results in a fatal error:
This pull request adds a check for the Wearable API availability both in
WearDeviceRepositoryand inWearAssetTransmitter.Where the API is not available,
WearDeviceRepositoryreports that no device is connected andWearAssetTransmitterreports that no transmission is ongoing.